Revert "Use XmlLint against tool configurations (PHPUnit, PHPCS, Psalm)"
#122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This revert can be reverted once laminas/laminas-continuous-integration-action#123 is merged. @Ocramius is there a way to ensure we require the correct version of that in this when it is? |
|
I think it always uses the latest version, which is a bit of a pain... |
|
Monorepo will come - when I find some more time and passion to work on this. |
|
Fix has been released as https://github.com/laminas/laminas-continuous-integration-action/releases/tag/1.24.0. This revert can be reverted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #31
As discussed with @internalsystemerror on slack, this didn't work as expected, since it leads to failing builds all over the place.
Reverting for now, and will be re-applied to
1.15.xin future, once ready.