Allow object jobs in the "checks" configuration array #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core.warning is not the same as console.log, and needs a single string. Concatenate message with JSON.stringify() of second and later arguments. Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Adds functionality to validate checks found in the "checks" array, including the ability to validate and normalize the "job" element. If the "job" element is a string, it attempts to parse it, raising a warning if the job is unparseable, and excluding it from the list of checks returned. If the "job" is parseable and/or an object, it then validates that a valid PHP version is present, a valid "dependencies" set is specified, and that a command is present and a string. If valid, the job is serialized to JSON and the value reassigned in the check. Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch expands the functionality of the "checks.[].job" element to allow specifying it as an object. When so discovered, the action will now serialize it to JSON.
It also now performs validations and normalization on each "checks" element and each "job" to ensure they are well-formed; if not, a warning will be raised by the action, and the check will be omitted.