Skip to content

Properly parse GITHUB_BASE_REF #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

boesing
Copy link
Member

@boesing boesing commented Jul 11, 2023

Q A
Bugfix yes

Description

The GITHUB_BASE_REF environment variable is surrounded by quotes and thus, kinda breaks the JSON passed to the CI container in projects with enabled backwardCompatibilityCheck.

@boesing boesing added the Bug Something isn't working label Jul 11, 2023
@boesing boesing added this to the 1.23.1 milestone Jul 11, 2023
@boesing boesing merged commit a32891f into laminas:1.23.x Jul 11, 2023
@boesing boesing deleted the bugfix/normalize-base-ref branch July 11, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant