Skip to content

feature: introduce composer.json schema validation #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2021

Conversation

boesing
Copy link
Member

@boesing boesing commented Jul 12, 2021

Q A
BC Break no
New Feature yes

Description

This will verify that the composer.json of a project always matches the schema.
There are two caveats:

  • Only verify composer.json if there is one within the project
  • Copied composer.schema.json to this project to ensure it wont change

The reason why I've added the schema to this project is, that the schema might change in the future.
Lets take PSR-0 for example. There is absolutely no reason to support that for like forever.
As the schema.json on the getcomposer.org website is not versionized, I wanted to take this precaution.

I am open to change that to the https://getcomposer.org/schema.json if you think that we don't need this precaution.

This PR relates to #22 but only implements schema validation as suggested by @weierophinney

Copy link
Member

@weierophinney weierophinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@weierophinney weierophinney added this to the 1.8.0 milestone Aug 11, 2021
@weierophinney weierophinney merged commit c41509b into laminas:1.8.x Aug 11, 2021
@boesing boesing deleted the qa/composer-validation branch August 11, 2021 15:29
@weierophinney weierophinney linked an issue Aug 11, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add composer.json linting to every matrix
2 participants