Skip to content

Codeception checks #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 11, 2021
Merged

Conversation

boesing
Copy link
Member

@boesing boesing commented Aug 6, 2021

Q A
Documentation yes
New Feature yes

Description

Adds Codeception checks based on the presence of codeception.yml.dist or codeception.yml files.

@boesing boesing requested a review from weierophinney August 6, 2021 16:52
@boesing boesing changed the title Codeception test when codeception.yml is available Codeception checks when codeception.yml is available Aug 6, 2021
@boesing boesing changed the title Codeception checks when codeception.yml is available Codeception checks Aug 6, 2021
Copy link
Member

@weierophinney weierophinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

I know we don't necessarily use this for Laminas, but I also know others are adopting our CI, so it makes sense to accommodate it!

@weierophinney weierophinney added this to the 1.8.0 milestone Aug 11, 2021
@boesing
Copy link
Member Author

boesing commented Aug 11, 2021

I am not sure if this might use all php versions as well with minor/latest - so the same way as we do for unit testing now.
but we can optimize this later on as well.

@weierophinney weierophinney merged commit b35f569 into laminas:1.8.x Aug 11, 2021
@boesing boesing deleted the feature/codeception branch August 11, 2021 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants