Execute phpunit with locked version only on the minimum supported PHP version of a project

[boesing]

Q	A
Documentation	no
BC Break	yes
New Feature	yes

Description

As discussed in the latest TSC meeting on 2021-08-02, this changes the way on how PHP unit tests are being executed.

locked dependencies are used for PHPUnit with the minimum supported PHP version of a package.
This also changes the way QA checks are being executed. All QA checks are now executed on the minimum supported PHP version of a project as well.

[weierophinney]

Looks reasonable; main concern is that you're actually getting the minimum version, and not a random one.

[boesing]

I did some checks and it absolutely works:

→ cat composer.json 
{
    "require": {
        "php": "~8.0.0 || ^7.4"
    }
}

→ node index.js | grep "Using minimum"
Using minimum PHP version: 7.4

→ cat composer.json 
{
    "require": {
        "php": "^5.6 || 7.3 || ^8.0"
    }
}

→ node index.js | grep "Using minimum"
Using minimum PHP version: 5.6

→ cat composer.json 
{
    "require": {
        "php": "^5.3 || ^7.0 || ^8.0"
    }
}

→ node index.js | grep "Using minimum"
Using minimum PHP version: 5.6

It is as of now: yes, a project may state to support PHP <5.6 but CI will only run ^5.6 as we do not have other versions installed tho.

[weierophinney]

🚢

[weierophinney]

Removed the BC break label; it's a change to the generated matrix, but it's an improvement, as it provides better clarity for which version the lockfile should target, as well as reduces the number of jobs necessary to accomplish the same goal (determine if a new failure is due to adopting new features not supported in a minimum version of a requirement, or due to a BC breaking change in a later version of the requirement).