Update README to reflect actual features #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boesing
force-pushed
the
docs/add-missing-details
branch
from
e70f6be to
3895513
Compare
Signed-off-by: Maximilian Bösing <[email protected]>
boesing
force-pushed
the
docs/add-missing-details
branch
from
3895513 to
f9dea13
Compare
weierophinney
requested changes
Aug 17, 2021
… by project configuration Signed-off-by: Maximilian Bösing <[email protected]>
Signed-off-by: Maximilian Bösing <[email protected]>
weierophinney
approved these changes
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While working on implementing #46, I realized that the documentation does not fully reflect any feature which is hidden when having a deep-dive into the code.
I detected these missing features:
additional_checks"job" element can provide either{"php": "7.4"}or{"php": "*"}, the latter will execute that job on every PHP version supported by the projectcheckswill prevent any auto-detection of jobsignore_platform_reqs_8was missing in the.laminas-ci.jsonexamplestablePHPwas missing in the.laminas-ci.jsonexampleFurthermore, the documentation repeated the
jobconfiguration multiple time while not being in sync.