Skip to content

Add laminas-ci.json schema validation #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Oct 10, 2021

Conversation

boesing
Copy link
Member

@boesing boesing commented Sep 12, 2021

Q A
Documentation yes
Bugfix no
BC Break no
New Feature yes

Description

This PR introduces JSON schema validation for .laminas-ci.json while also disallowing .checks[].job to be a string.

More detailed list of changes

  • Allows .checks[].job.php to contain wildcard *
  • Allows .checks[].job.dependencies to contain wildcard *
  • Validates .checks[].job.php against the list of installable versions provided by src/config.js
  • Validates .laminas-ci.json with the new laminas-ci.schema.json

Fixes #49

@boesing boesing added this to the 1.11.0 milestone Sep 12, 2021
…malize-checks-from-config`

Signed-off-by: Maximilian Bösing <[email protected]>
…r better reusability

Signed-off-by: Maximilian Bösing <[email protected]>
Signed-off-by: Maximilian Bösing <[email protected]>
…`laminas-ci.schema.json` for `.checks[].job` with a minLength of 2 characters

Signed-off-by: Maximilian Bösing <[email protected]>
…hp` and `dependencies` in `.checks`

Signed-off-by: Maximilian Bösing <[email protected]>
Signed-off-by: Maximilian Bösing <[email protected]>
@boesing boesing force-pushed the feature/laminas-ci-json-schema branch from 4a810d6 to 33338c0 Compare October 10, 2021 15:02
@boesing boesing merged commit d0a7143 into laminas:1.11.x Oct 10, 2021
@boesing boesing deleted the feature/laminas-ci-json-schema branch October 10, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON Schema for .laminas-ci.json
1 participant