Run infection via phpdbg by default, since phpdbg is pre-installed with PHP
#70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…led with PHP This removes the need for installing `pcov` or `xdebug` in environments that need to run mutation tests: `phpdbg` being pre-installed means that any bugs with it will also be reported to the PHP project, instead of dragging in bugs from third-party extensions. This also fixes builds for projects that did not declare `ext-pcov` or `ext-xdebug` as dependencies in `require-dev`: no need to have those, when running this task.
|
I am not sure if We do actually only link Not sure what kind of binary |
|
As discussed with @boesing, will need to adjust |
Ocramius
added a commit
to Ocramius/laminas-continuous-integration-action
that referenced
this pull request
Oct 11, 2021
…script This allows usage of the built-in PHP debugger, without the need to install larger third-party extensions. This is a requirement for laminas/laminas-ci-matrix-action#70
boesing
approved these changes
Oct 11, 2021
There was a problem hiding this comment.
LGTM
https://github.com/laminas/laminas-continuous-integration-action/releases/tag/1.13.2 is already published and thus this should work.
You can verify this by creating the matrix with:
docker build . -t laminas/laminas-ci-matrix-action:dev-local
# The next command should output the JSON to pass to the container
docker run -v $(realpath .):/github/workspace -w=/github/workspace laminas/laminas-ci-matrix-action:dev-local
# The next command should pull the latest version of the CI Container
docker pull ghcr.io/laminas/laminas-continuous-integration:1
# Pass the JSON to the container
docker run -v $(realpath .):/github/workspace -w=/github/workspace ghcr.io/laminas/laminas-continious-integration-action:1 '{}'
|
@boesing just verified this on 🚢 + 🏷️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes the need for installing
pcovorxdebugin environments that need torun mutation tests:
phpdbgbeing pre-installed means that any bugs with it willalso be reported to the PHP project, instead of dragging in bugs from third-party
extensions.
This also fixes builds for projects that did not declare
ext-pcovorext-xdebugas dependencies in
require-dev: no need to have those, when running this task.