Introduce ESLint #82
Introduce ESLint #82
Conversation
Signed-off-by: Maximilian Bösing <[email protected]>
Signed-off-by: Maximilian Bösing <[email protected]>
Signed-off-by: Maximilian Bösing <[email protected]>
… the latest version available Signed-off-by: Maximilian Bösing <[email protected]>
Signed-off-by: Maximilian Bösing <[email protected]>
|
|
||
| dependencies = 'locked'; | ||
|
|
||
| ignorePhpPlatformRequirement = false; |
There was a problem hiding this comment.
Aren't these changes potential BC breaks?
There was a problem hiding this comment.
I'd say no as we do not provide an API here, right?
Only changing application code. Input configs and output matrix havent changed.
There was a problem hiding this comment.
Isn't this serialized and given to the next action?
There was a problem hiding this comment.
Nope, there is a dedicated method toJSON for that.
| return [new Job( | ||
| command + ' on PHP ' + config.minimum_version, | ||
| return [ new Job( | ||
| `${command } on PHP ${ config.minimumVersion}`, | ||
| JSON.stringify(new Command( |
There was a problem hiding this comment.
This JSON.stringify() will produce a data structure that is potentially quite different from what we had before 🤔
There was a problem hiding this comment.
why do you think so? cant really follow.
JSON.stringify is already part of the latest version?
There was a problem hiding this comment.
Sorry, I mean that the structure passed to it will be a bit different :)
There was a problem hiding this comment.
Ah I see what you mean and yes indeed, it changes a little bit.
Good catch. We are missing to call toJSON here.
There is some "normalization" stuff going on in another function which converts the string back to an object and verifies properties.
There it will not properly match anymore. 👍🏼
Signed-off-by: Maximilian Bösing <[email protected]>
Signed-off-by: Maximilian Bösing <[email protected]>
Signed-off-by: Maximilian Bösing <[email protected]>
Signed-off-by: Maximilian Bösing <[email protected]>
|
Currently working on switching to typescript while also restructuring the whole application. Will see if I can finish #62 with some integration tests of "projects" so we have a bunch of tests which can also be executed by the new typescript version of this application. If that is something we are fine with, I'd close this PR to instead use |
Description
Adds ESLint to this project to provide at least some CI pipeline for the moment.