Additional integration tests #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maximilian Bösing <[email protected]>
Signed-off-by: Maximilian Bösing <[email protected]>
… in exclusion name Signed-off-by: Maximilian Bösing <[email protected]>
…iner We do have to change the `entrypoint` of the docker container to verify that the `diff` is really passed to our GHA within CI. Therefore, we had to add a `shebang` to the `index.js` along with removing the `node` command prefix. Signed-off-by: Maximilian Bösing <[email protected]>
Signed-off-by: Maximilian Bösing <[email protected]>
Signed-off-by: Maximilian Bösing <[email protected]>
…esh added tests Signed-off-by: Maximilian Bösing <[email protected]>
Ocramius
approved these changes
Jun 29, 2022
Signed-off-by: Maximilian Bösing <[email protected]>
…checks` Signed-off-by: Maximilian Bösing <[email protected]>
Signed-off-by: Maximilian Bösing <[email protected]>
Since we do use filesystem access to actually verify if the directory/file exist, we do have to create the `docs/book` directory to make the matcher pass. Signed-off-by: Maximilian Bösing <[email protected]>
…dy target only one PHP version Signed-off-by: Maximilian Bösing <[email protected]>
boesing
force-pushed
the
qa/additional-tests
branch
from
fa76427 to
e6cfa26
Compare
Signed-off-by: Maximilian Bösing <[email protected]>
Signed-off-by: Maximilian Bösing <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While working on #83, I find more and more tests which should be added before we are merging the typescript refactoring.
This will ensure that we are backwards compatible.