Skip to content

Introduce after_script which will be executed after the command #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

boesing
Copy link
Member

@boesing boesing commented Jul 18, 2022

Q A
Documentation yes
New Feature yes

Description

This adds the possibility of passing a list of commands to be executed after each command. Even tho, a command failed, the after_script commands will be called.

@boesing boesing added this to the 1.22.0 milestone Jul 18, 2022
@boesing boesing changed the title Introduce after_script which will be executed prior the command Introduce after_script which will be executed after the command Jul 19, 2022
@Ocramius Ocramius self-assigned this Jul 19, 2022
@Ocramius
Copy link
Member

@boesing once this is rebased, we can release, I think

Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM, just needs rebase

Signed-off-by: Maximilian Bösing <[email protected]>
@boesing boesing force-pushed the feature/after_script branch from d663472 to 7b76f82 Compare July 19, 2022 09:31
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @boesing!

@Ocramius Ocramius merged commit d3d26b1 into laminas:1.22.x Jul 19, 2022
@boesing boesing deleted the feature/after_script branch July 19, 2022 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants