Skip to content

Fix #116: ensure .ini settings are reset for both phpdbg and php-cli SAPIs #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Ocramius
Copy link
Member

Q A
Documentation no
Bugfix yes
BC Break no
New Feature no
RFC no
QA no

Description

Fixes #116

This is caused by phpdbg and php-cli using different configuration paths, in the ubuntu-distributed PHP .deb setup.

I targeted 1.22.0, since this doesn't really need backporting.

@Ocramius Ocramius added the Bug Something isn't working label Jul 25, 2022
@Ocramius Ocramius added this to the 1.22.0 milestone Jul 25, 2022
Copy link
Member

@internalsystemerror internalsystemerror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ocramius Ocramius self-assigned this Jul 25, 2022
@Ocramius Ocramius merged commit 190e358 into laminas:1.22.x Jul 25, 2022
@Ocramius Ocramius deleted the fix/#116-align-phpdbg-to-cli-sapi-settings branch July 25, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set memory_limit=-1 by default
2 participants