Ensure newlines are propagated to php.ini settings #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bash does not like to capture newlines into variables. As such, this patch concatenates php.ini settings using the string `{NL}`, which is then translated to a newline when pushing to the php.ini settings file.
Fixes laminas#7
Signed-off-by: Matthew Weier O'Phinney <[email protected]>
glensc
reviewed
Apr 1, 2021
| @@ -151,7 +151,7 @@ fi | |||
|
|
|||
| if [[ "${INI}" != "" ]];then | |||
| echo "Installing php.ini settings" | |||
| echo $INI > /etc/php/${PHP}/cli/conf.d/99-settings.ini | |||
| echo $INI | sed "s/{NL}/\n/g" > /etc/php/${PHP}/cli/conf.d/99-settings.ini | |||
There was a problem hiding this comment.
this is a super dumb "fix", now values can't contain {NL}!
bash has no problems containing newlines!
sending PR with actual fix with quoting echo arguments!
There was a problem hiding this comment.
There was a problem hiding this comment.
1st of all: there is nothing dumb when not having all scenarios in mind
2nd: you might want to learn how to communicate such problems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bash does not like to capture newlines into variables. As such, this patch concatenates php.ini settings using the string
{NL}, which is then translated to a newline when pushing to the php.ini settings file.Fixes #7