Skip to content

Update dependency markdownlint-cli2 to v0.12.1 #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 1, 2022

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
markdownlint-cli2 0.3.2 -> 0.12.1 age adoption passing confidence

Release Notes

DavidAnson/markdownlint-cli2 (markdownlint-cli2)

v0.12.1

Compare Source

  • Update JSONC parsing to handle trailing commas
  • Add documentation links to JSON schema
  • Update dependencies

v0.12.0

Compare Source

  • Remove deprecated markdownlint-cli2-config entry point
    • Use markdownlint-cli2 --config ... instead
  • Remove deprecated markdownlint-cli2-fix entry point
    • Use markdownlint-cli2 --fix ... instead
  • Add --help and --no-globs parameters
  • Improve and document included JSON schemas
  • Update dependencies (including markdownlint)

v0.11.0

Compare Source

  • Add modulePaths configuration option
  • Update dependencies (including markdownlint)
  • Remove support for end-of-life Node 16

v0.10.0

Compare Source

  • Add showFound configuration option
  • Add .markdownlint-cli2.jsonc config schema
  • Update dependencies (including markdownlint)

v0.9.2

Compare Source

  • Remove npm-shrinkwrap.json entirely to avoid npm failures

v0.9.1

Compare Source

  • Remove devDependencies from npm-shrinkwrap.json to avoid npm failures

v0.9.0

Compare Source

  • Add support for Node.js's package.json as a configuration file source
  • Add output formatter for Static Analysis Results Interchange Format/SARIF
  • Bundle npm-shrinkwrap.json for reproducible/faster installs
  • Update dependencies (including markdownlint)

v0.8.1

Compare Source

  • Handle --config edge case

v0.8.0

Compare Source

  • Add support for --config and --fix parameters
  • Update dependencies (including markdownlint)
  • Remove support for end-of-life Node 14

v0.7.1

Compare Source

  • Update dependencies (including markdownlint)

v0.7.0

Compare Source

  • Add support for extends in config property of .markdownlint-cli2.* files
  • Build and publish davidanson/markdownlint-cli2-rules Docker container image
  • Update dependencies (including markdownlint)

v0.6.0

Compare Source

  • Update dependencies (including markdownlint)

v0.5.1

Compare Source

  • Update dependencies

v0.5.0

Compare Source

  • New rules
  • Support modules (MJS) everywhere
  • Include dotfiles

v0.4.0

Compare Source

  • New rules
  • Async custom rules
  • Explicit config
  • CJS (breaking)

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

Read more information about the use of Renovate Bot within Laminas.

@renovate renovate bot added the renovate label Nov 1, 2022
@Ocramius Ocramius requested a review from froschdesign November 1, 2022 15:28
@Ocramius Ocramius added this to the 1.28.0 milestone Nov 1, 2022
@Ocramius
Copy link
Member

Ocramius commented Nov 1, 2022

Unsure about this one: if it turns out to be a BC break, we may need to defer it.

The tags convey zero upgrade/change notes.

Therefore poked @froschdesign about a decision here.

Build also failed related to this dependency upgrade:

 #0 2.777 found 0 vulnerabilities
#0 2.869 internal/modules/cjs/loader.js:818
#0 2.869   throw err;
#0 2.869   ^
#0 2.869 
#0 2.869 Error: Cannot find module 'node:path'
#0 2.869 Require stack:
#0 2.869 - /markdownlint/node_modules/markdownlint-cli2/markdownlint-cli2.js
#0 2.869     at Function.Module._resolveFilename (internal/modules/cjs/loader.js:815:15)
#0 2.869     at Function.Module._load (internal/modules/cjs/loader.js:667:27)
#0 2.869     at Module.require (internal/modules/cjs/loader.js:887:19)
#0 2.869     at require (internal/modules/cjs/helpers.js:74:18)
#0 2.869     at Object.<anonymous> (/markdownlint/node_modules/markdownlint-cli2/markdownlint-cli2.js:13:14)
#0 2.869     at Module._compile (internal/modules/cjs/loader.js:999:30)
#0 2.869     at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
#0 2.869     at Module.load (internal/modules/cjs/loader.js:863:32)
#0 2.869     at Function.Module._load (internal/modules/cjs/loader.js:708:14)
#0 2.869     at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:60:12) {
#0 2.869   code: 'MODULE_NOT_FOUND',
#0 2.869   requireStack: [
#0 2.869     '/markdownlint/node_modules/markdownlint-cli2/markdownlint-cli2.js'
#0 2.869   ]
#0 2.869 }
#17 ERROR: process "/bin/sh -c cd /markdownlint     && npm ci     && node_modules/.bin/markdownlint-cli2 /test-files/dummy-ok-markdown-test-file.md     && if node_modules/.bin/markdownlint-cli2 /test-files/dummy-ko-markdown-test-file.md; then exit 1; else exit 0; fi" did not complete successfully: exit code: 1

@Ocramius Ocramius removed this from the 1.28.0 milestone Nov 1, 2022
@renovate renovate bot force-pushed the renovate/all-minor-patch branch from 9bc787d to 8e3dc1f Compare November 8, 2022 09:50
@froschdesign
Copy link
Member

Looks like we will have to wait here: DavidAnson/markdownlint-cli2#72

@renovate renovate bot force-pushed the renovate/all-minor-patch branch from 8e3dc1f to f87b5a0 Compare November 16, 2022 17:59
@renovate renovate bot force-pushed the renovate/all-minor-patch branch from f87b5a0 to 3bfb416 Compare December 3, 2022 02:39
@renovate renovate bot force-pushed the renovate/all-minor-patch branch 2 times, most recently from 3c9c298 to 14d84dc Compare December 16, 2022 23:07
@Ocramius Ocramius changed the base branch from 1.28.x to 1.33.x December 17, 2022 04:38
@renovate renovate bot force-pushed the renovate/all-minor-patch branch from 14d84dc to a3c3087 Compare December 22, 2022 20:21
@renovate renovate bot changed the title Update dependency markdownlint-cli2 to v0.5.1 Update all non-major dependencies Dec 22, 2022
@renovate renovate bot force-pushed the renovate/all-minor-patch branch from a3c3087 to ee81d76 Compare December 23, 2022 18:00
@renovate renovate bot force-pushed the renovate/all-minor-patch branch from ee81d76 to a7be6c6 Compare December 31, 2022 02:29
@renovate renovate bot force-pushed the renovate/all-minor-patch branch from a7be6c6 to 998b887 Compare January 12, 2023 04:18
@renovate renovate bot force-pushed the renovate/all-minor-patch branch from 998b887 to 029c517 Compare January 30, 2023 22:18
@renovate renovate bot force-pushed the renovate/all-minor-patch branch 2 times, most recently from dc20c20 to f9543b9 Compare February 10, 2023 19:49
@renovate renovate bot force-pushed the renovate/all-minor-patch branch from f9543b9 to 286f2aa Compare February 15, 2023 21:27
@internalsystemerror
Copy link
Member

That issue was fixed in v0.6.0 which this PR wants to merge to, however that requires "nodejs": ">=14.18.0" and we're installing v12 from apt in the container.

We could install this using NodeSource instead?

@renovate renovate bot force-pushed the renovate/all-minor-patch branch from 286f2aa to f8e774d Compare March 21, 2023 20:25
@renovate renovate bot force-pushed the renovate/all-minor-patch branch 3 times, most recently from 0618944 to 528a31e Compare June 2, 2023 03:35
@internalsystemerror internalsystemerror added this to the 1.33.0 milestone Jun 2, 2023
@renovate renovate bot force-pushed the renovate/all-minor-patch branch from 528a31e to 667985f Compare June 2, 2023 16:32
@internalsystemerror
Copy link
Member

It's still installing node v12 🤔 . I wonder if we need to run apt update again AFTER we add the nodesource repository. I'll investigate.

@renovate renovate bot force-pushed the renovate/all-minor-patch branch 2 times, most recently from 00f6e74 to c112a7d Compare October 8, 2023 14:27
@renovate renovate bot changed the base branch from 1.36.x to 1.37.x October 8, 2023 14:27
@renovate renovate bot force-pushed the renovate/all-minor-patch branch from c112a7d to ae27f9b Compare October 10, 2023 03:47
@renovate renovate bot force-pushed the renovate/all-minor-patch branch 2 times, most recently from 4591b31 to d5cdaad Compare October 24, 2023 06:55
@renovate renovate bot force-pushed the renovate/all-minor-patch branch 3 times, most recently from c1d58b3 to f967b1d Compare November 21, 2023 04:23
@renovate renovate bot force-pushed the renovate/all-minor-patch branch 2 times, most recently from 2c5416a to cd8c488 Compare December 5, 2023 07:47
@renovate renovate bot force-pushed the renovate/all-minor-patch branch 2 times, most recently from 3d91e7e to 85017dd Compare December 12, 2023 06:37
@renovate renovate bot force-pushed the renovate/all-minor-patch branch 2 times, most recently from 0a6a069 to 696c475 Compare December 26, 2023 06:30
@renovate renovate bot force-pushed the renovate/all-minor-patch branch 2 times, most recently from 2eb5fad to f630efc Compare January 9, 2024 07:14
@renovate renovate bot force-pushed the renovate/all-minor-patch branch 2 times, most recently from e642c9c to bb4bfa5 Compare January 14, 2024 23:27
@renovate renovate bot force-pushed the renovate/all-minor-patch branch from bb4bfa5 to 9e45d9a Compare January 31, 2024 12:29
@renovate renovate bot changed the base branch from 1.37.x to 1.38.x January 31, 2024 12:29
@renovate renovate bot force-pushed the renovate/all-minor-patch branch from 9e45d9a to ac19e7c Compare January 31, 2024 12:42
@renovate renovate bot changed the title Update all non-major dependencies Update dependency markdownlint-cli2 to v0.12.1 Jan 31, 2024
| datasource | package           | from  | to     |
| ---------- | ----------------- | ----- | ------ |
| npm        | markdownlint-cli2 | 0.3.2 | 0.12.1 |


Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate renovate bot force-pushed the renovate/all-minor-patch branch from ac19e7c to 33821f8 Compare January 31, 2024 14:21
@Xerkus Xerkus added this to the 1.38.0 milestone Jan 31, 2024
@Xerkus Xerkus merged commit 5e0ed7b into 1.38.x Jan 31, 2024
@Xerkus Xerkus deleted the renovate/all-minor-patch branch January 31, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants