Skip to content

Pass PHP version (<major>.<minor>) to the scripts #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2023

Conversation

boesing
Copy link
Member

@boesing boesing commented Jul 17, 2023

Q A
Bugfix yes
New Feature yes

Description

These changes do both fix an issue where @latest is passed to the extension installer and provides and provide a new feature by passing the PHP variable (which does not contain @latest anymore) to the scripts which can be implemented by projects:

  • pre-run.sh
  • pre-install.sh
  • post-run.sh

….sh`, `pre-install.sh` and `post-run.sh`

Signed-off-by: Maximilian Bösing <[email protected]>
@boesing boesing added Bug Something isn't working Enhancement labels Jul 17, 2023
@boesing boesing added this to the 1.34.0 milestone Jul 17, 2023
@boesing boesing merged commit 625e2b4 into laminas:1.34.x Jul 17, 2023
@boesing boesing deleted the feature/pass-php-version-to-scripts branch July 17, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants