feat: use null as "nothing to do"
#23
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maximilian Bösing <[email protected]>
Signed-off-by: Maximilian Bösing <[email protected]>
This was referenced Apr 8, 2021
|
Will apply feedback from laminas/laminas-ci-matrix-action#26 and create a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the matrix generation creates the command
echo 'No checks discovered'.Somehow, the
.laminas-ci.jsoncontent is not merged and thus, the check fails when an extension is required to run.Imho, there should be some kind of "early success" when there is nothing to check. Thus, neither a
checkoutnorcomposer installshould be performed.With this PR, I'd like to introduce
nullfor thecommand. Ifnullis passed (either as string or asnull-type), no command is being executed and the check is considered as successful.