Skip to content

Fix installation of MSSQL extension #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 12, 2024
Merged

Conversation

gsteel
Copy link
Member

@gsteel gsteel commented May 8, 2024

Q A
Bugfix yes

Description

CI is currently failing - looks like the asset locations are incorrect for https://github.com/microsoft/msphpsql/releases/tag/v5.12.0

@gsteel gsteel force-pushed the fix-ms-sql-install branch from c1b96e3 to 4f025cc Compare May 8, 2024 09:12
@gsteel gsteel requested a review from Xerkus May 8, 2024 09:13
@gsteel gsteel force-pushed the fix-ms-sql-install branch 2 times, most recently from 7dc4aa8 to ff46fa3 Compare May 8, 2024 09:29
Copy link
Member

@Xerkus Xerkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When did they change artifacts?

@gsteel gsteel force-pushed the fix-ms-sql-install branch from ff46fa3 to da35054 Compare May 8, 2024 09:45
@gsteel
Copy link
Member Author

gsteel commented May 8, 2024

When did they change artifacts?

I have no idea - just saw that CI was failing 🤷‍♂️

@gsteel gsteel changed the title Attempt to fix installation of MSSQL extension Fix installation of MSSQL extension May 8, 2024
@gsteel gsteel force-pushed the fix-ms-sql-install branch from 60fa045 to 9fbb5fe Compare May 8, 2024 10:02
Co-authored-by: Aleksei Khudiakov <[email protected]>
Signed-off-by: George Steel <[email protected]>
Signed-off-by: George Steel <[email protected]>
@gsteel gsteel force-pushed the fix-ms-sql-install branch from 9fbb5fe to d59bc92 Compare May 8, 2024 10:04
@gsteel gsteel added this to the 1.40.0 milestone Jun 12, 2024
@gsteel gsteel added the Bug Something isn't working label Jun 12, 2024
@gsteel gsteel self-assigned this Jun 12, 2024
@gsteel gsteel merged commit 9652956 into laminas:1.40.x Jun 12, 2024
@gsteel gsteel deleted the fix-ms-sql-install branch June 12, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants