Skip to content

Initial support for PHP 8.4 #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,22 @@ RUN set -eux; \
php8.3-xml \
php8.3-xsl \
php8.3-zip \
\
php8.4-cli \
php8.4-bcmath \
php8.4-bz2 \
php8.4-curl \
php8.4-dev \
php8.4-fileinfo \
php8.4-intl \
php8.4-mbstring \
php8.4-phar \
php8.4-phpdbg \
php8.4-readline \
php8.4-sockets \
php8.4-xml \
php8.4-xsl \
php8.4-zip \
Comment on lines +256 to +271
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waaait: did docker build already run on this? Or did I get baited by a green checkmark?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-checked logs: it's there :-)

&& apt autoremove -y \
&& apt clean

Expand Down
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,7 @@ The container the action provides and consumes builds off the ubuntu:focal image
- 8.1
- 8.2
- 8.3
- 8.4

Each provides the following extensions by default:

Expand Down
2 changes: 1 addition & 1 deletion scripts/php_ini_dev_settings.sh
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ SUBSTITUTIONS+=('s/mysqlnd.collect_memory_statistics ?= ?(On|Off)/mysqlnd.collec
SUBSTITUTIONS+=('s/zend.assertions ?= ?(-1|1)/zend.assertions = 1/')
SUBSTITUTIONS+=('s/opcache.huge_code_pages ?= ?(0|1)/opcache.huge_code_pages = 0/')

for PHP_VERSION in 5.6 7.0 7.1 7.2 7.3 7.4 8.0 8.1 8.2 8.3;do
for PHP_VERSION in 5.6 7.0 7.1 7.2 7.3 7.4 8.0 8.1 8.2 8.3 8.4;do
for PHP_SAPI in cli phpdbg; do
INI_FILE="/etc/php/${PHP_VERSION}/${PHP_SAPI}/php.ini"
for SUBSTITUTION in "${SUBSTITUTIONS[@]}";do
Expand Down
Loading