Merge release 1.6.2 into 1.7.x #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
As reported in Slack, if a value is missing, `jq` returns `null`.
When run normally (e.g., `echo "${JOB}" | jq -r '.somekey'`), this becomes an empty string when the key is missing.
However, when run within a subshell (e.g., when assigning to a variable, such as `VALUE=$(echo "${JOB}" | jq -r '.somekey')`), the string `null` is returned.
Fortunately, `jq` allows specifying an alternative value if a value is missing or `false` or `null`, via the `//` operator.
This patch adds alternatives everywhere `jq` is invoked when assigning a variable.
Signed-off-by: Matthew Weier O'Phinney <[email protected]>
…tring Provide defaults for missing JOB values
weierophinney
deleted the
1.6.x-merge-up-into-1.7.x_607079febb9e14.94132860
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes for 1.6.2
Fixed
entrypoint.shscript as derived from passing the$JOBtojqto ensure sane defaults are used if no value is matched. This fix mainly affects people using the tool viadocker runto run jobs locally.1.6.2
Bug