-
-
Notifications
You must be signed in to change notification settings - Fork 20
Add ShellCheck to CI #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Filippo Tessarotto <[email protected]>
Signed-off-by: Filippo Tessarotto <[email protected]>
Signed-off-by: Filippo Tessarotto <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I wonder if it would be possible to just add the regular laminas CI workflow to this repository and the matrix automatically detects bash files as it does for Markdown and YAML files.
Not sure if it makes sense to use CI for CI (CIception) but having the ability to check shell scripts in every package would be a cool thing imho.
The bike is already invited: it includes GitHub action too. NOTE: I have not verified or used how it works. it's on my ever-growing to-do list to do so. |
Oh thats awesome! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
My feeling is that, for now, we need linting of the entry point to ensure it is valid for each release. For other pieces, I'd argue we do some PoCs, and then come back with an RFC or a PR. |
Close #27