Skip to content

Add ShellCheck to CI #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 12, 2021
Merged

Add ShellCheck to CI #30

merged 3 commits into from
Apr 12, 2021

Conversation

Slamdunk
Copy link
Contributor

Close #27

Signed-off-by: Filippo Tessarotto <[email protected]>
Signed-off-by: Filippo Tessarotto <[email protected]>
@Slamdunk
Copy link
Contributor Author

🚀

image

Signed-off-by: Filippo Tessarotto <[email protected]>
Copy link
Member

@boesing boesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I wonder if it would be possible to just add the regular laminas CI workflow to this repository and the matrix automatically detects bash files as it does for Markdown and YAML files.

Not sure if it makes sense to use CI for CI (CIception) but having the ability to check shell scripts in every package would be a cool thing imho.

@glensc
Copy link
Contributor

glensc commented Apr 12, 2021

The bike is already invited:

it includes GitHub action too.

NOTE: I have not verified or used how it works. it's on my ever-growing to-do list to do so.

@boesing
Copy link
Member

boesing commented Apr 12, 2021

Oh thats awesome!
I wonder if the laminas-ci-matrix-action can also create non-laminas actions (so using existing actions aswell instead of only laminas-continous-integration-container actions (which are referring to this component).
Thus, we could generate existing actions like the github/super-linter which looks like an official action of github.

Copy link
Member

@weierophinney weierophinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@weierophinney
Copy link
Member

My feeling is that, for now, we need linting of the entry point to ensure it is valid for each release. For other pieces, I'd argue we do some PoCs, and then come back with an RFC or a PR.

@weierophinney weierophinney merged commit 4ca9f9e into laminas:1.7.x Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Linting for bash scripts
4 participants