Skip to content

Add support for ignore_platform_reqs_8 job flag #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2021
Merged

Add support for ignore_platform_reqs_8 job flag #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ The JSON string should represent an object with the following information:
"php.ini directives, one per element; e.g. 'memory_limit=-1'"
],
"dependencies": "dependencies to test against; one of lowest, locked, latest",
"ignore_platform_reqs_on_8": "(boolean; OPTIONAL) Whether or not to ignore platform requirements on PHP 8; defaults to true",
"command": "command to run to perform the check (empty in case you dont want to excecute any command)"
}
```
Expand Down
6 changes: 4 additions & 2 deletions entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,9 @@ function checkout {
function composer_install {
local DEPS=$1
local PHP=$2
local IGNORE_PLATFORM_REQS_ON_8=$3
local COMPOSER_ARGS="--ansi --no-interaction --no-progress --prefer-dist"
if [[ "${PHP}" =~ ^8. ]];then
if [[ "${IGNORE_PLATFORM_REQS_ON_8}" == "yes" && "${PHP}" =~ ^8. ]];then
# TODO: Remove this when it's not an issue, and/or provide a config
# option to disable the behavior.
COMPOSER_ARGS="${COMPOSER_ARGS} --ignore-platform-req=php"
Expand Down Expand Up @@ -140,6 +141,7 @@ fi
EXTENSIONS=$(echo "${JOB}" | jq -r ".extensions // [] | map(\"php${PHP}-\"+.) | join(\" \")")
INI=$(echo "${JOB}" | jq -r '.ini // [] | join("\n")')
DEPS=$(echo "${JOB}" | jq -r '.dependencies // "locked"')
IGNORE_PLATFORM_REQS_ON_8=$(echo "${JOB}" | jq -r 'if has("ignore_platform_reqs_8") | not then "yes" elif .ignore_platform_reqs_8 then "yes" else "no" end')

if [[ "${EXTENSIONS}" != "" ]];then
ENABLE_SQLSRV=false
Expand Down Expand Up @@ -171,7 +173,7 @@ echo "PHP version: $(php --version)"
echo "Installed extensions:"
php -m

composer_install "${DEPS}" "${PHP}"
composer_install "${DEPS}" "${PHP}" "${IGNORE_PLATFORM_REQS_ON_8}"

if [[ "${COMMAND}" =~ phpunit ]];then
echo "Setting up PHPUnit problem matcher"
Expand Down