Skip to content

Ensure pull request branch name does not cause collisions #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

weierophinney
Copy link
Member

Similar to the issue reported in laminas/laminas-ci-matrix-action#29, we need to ensure that when we fetch the $GITHUB_REF, we fetch it into a branch that is named differently than the base branch to avoid collisions and errors.

This patch accomplishes it by adding a pull/ prefix to the pull request branch name.

@weierophinney weierophinney added this to the 1.7.1 milestone Apr 20, 2021
@weierophinney weierophinney added the Bug Something isn't working label Apr 20, 2021
… branch

Similar to the issue reported in laminas/laminas-ci-matrix-action#29, we need to ensure that when we fetch the `$GITHUB_REF`, we fetch it into a branch that is named differently than the base branch to avoid collisions and errors.

This patch accomplishes it by adding a `pull/` prefix to the pull request branch name.

Signed-off-by: Matthew Weier O'Phinney <[email protected]>
@weierophinney weierophinney force-pushed the hotfix/pull_request_branch branch from 8e8bf05 to e44b7bc Compare April 20, 2021 20:10
@weierophinney weierophinney merged commit 69b9fb8 into laminas:1.7.x Apr 20, 2021
@weierophinney weierophinney deleted the hotfix/pull_request_branch branch April 20, 2021 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant