Add Swoole extension to container #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch compiles and installs the Swoole extension (at version 4.6.7) for PHP versions 7.3, 7.4, and 8.0. It is NOT enabled by default; enablement is done selectively, as it is done with sqlsrv (combination of a mods-available INI file, and conditional logic when enabling extensions in the entrypoint). I have built the container locally, and it builds correctly; more importantly, I then ran it against the mezzio-swoole library to ensure I could run unit tests with it, and tests passed. At some point, we will likely want to: - Add a script per extension we want to install manually - Add a script for each of the various functions/conditionals in the entrypoint to make it more modular For now, however, this works, and will allow us to move forward with adding GHA to mezzio-swoole. Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Per shellcheck Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch compiles and installs the Swoole extension (at version 4.6.7) for PHP versions 7.3, 7.4, and 8.0. It is NOT enabled by default; enablement is done selectively, as it is done with sqlsrv (combination of a mods-available INI file, and conditional logic when enabling extensions in the entrypoint). I have built the container locally, and it builds correctly; more importantly, I then ran it against the mezzio-swoole library to ensure I could run unit tests with it, and tests passed.
At some point, we will likely want to:
For now, however, this works, and will allow us to move forward with adding GHA to mezzio-swoole.