Inject GITHUB_TOKEN in composer config when present #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To help prevent hitting rate limits. Patch also fixes errors flagged by shellcheck. Signed-off-by: Matthew Weier O'Phinney <[email protected]>
weierophinney
commented
Jun 2, 2021
Comment on lines
+167
to
+170
| # If a token is present, tell Composer about it so we can avoid rate limits | ||
| if [[ "${GITHUB_TOKEN}" != "" ]];then | ||
| composer config --global github-oauth.github.com "${GITHUB_TOKEN}" | ||
| fi |
There was a problem hiding this comment.
This is the primary change to review.
Xerkus
approved these changes
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In laminas-api-tools/api-tools-rpc#8, I ran into an issue whereby installing lowest or latest dependencies resulted in the Composer error "Could not authenticate against github.com", which occurs when rate limits have been reached.
These can be prevented by providing the GITHUB_TOKEN secret to the container, and using it to configure Composer to authenticate against GitHub.
The patch also fixes errors flagged by shellcheck.