Use pre-build Swoole/OpenSwoole extensions #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of building Swoole each time we change the container, we can pre-build it once and pull it in, similar to how we consume the sqlsrv extension. I've created a project, [laminas-ci-swoole-builder](https://github.com/weierophinney/laminas-ci-swoole-builder) that builds both Swoole and OpenSwoole using containers mimicing the Laminas-CI setup. The artifacts are then packaged and uploaded to an S3 bucket, allowing us to pull them in here. This can eventually be managed directly by Laminas, but in the meantime, should speed up our container builds, and give us quicker turnaround on new Swoole and OpenSwoole versions. Signed-off-by: Matthew Weier O'Phinney <[email protected]>
weierophinney
force-pushed
the
feature/prebuilt-swoole
branch
from
1f3da4f to
8f95621
Compare
|
Relevant part of the build starts here: https://github.com/laminas/laminas-continuous-integration-action/runs/4383348186?check_suite_focus=true#step:9:6645 |
|
And build times drop from 12:43 to 4:42. 🎉 |
Ocramius
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of building Swoole each time we change the container, we can pre-build it once and pull it in, similar to how we consume the sqlsrv extension. I've created a project, laminas-ci-swoole-builder that builds both Swoole and OpenSwoole using containers mimicing the Laminas-CI setup. The artifacts are then packaged and uploaded to an S3 bucket, allowing us to pull them in here. This can eventually be managed directly by Laminas, but in the meantime, should speed up our container builds, and give us quicker turnaround on new Swoole and OpenSwoole versions.
The tarball contains
/etcand/usrsubtrees that include:This patch also: