Disable platform.php composer config for lowest/latest jobs
#79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per the February 2022 TSC meeting, when doing `composer update` operations, we should honor the current PHP version, and not the one listed in the platform.php configuration. Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Ocramius
approved these changes
Feb 7, 2022
| case $DEPS in | ||
| lowest) | ||
| echo "Installing lowest supported dependencies via Composer" | ||
| # Disable platform.php, if set | ||
| composer config --unset platform.php |
There was a problem hiding this comment.
Fancy, didn't know of this shortcut!
There was a problem hiding this comment.
@rdohms taught me to avoid manually updating composer.json whenever possible, and the config subcommand is our friend here. :)
Better, it doesn't emit an error if the setting isn't present, which ensures the script continues running in those cases.
Ocramius
changed the title
platform.php composer config for lowest/latest jobs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Per the February 2022 TSC meeting, when doing
composer updateoperations, we should honor the current PHP version, and not the one listed in the platform.php configuration.Renovate-Bot needs a platform.php setting to use when updating
composer.lockto ensure that it updates to dependencies supported by our minimum supported PHP version.However, when running CI, if such a setting is present, we'll never test against dependency versions supported by later PHP versions, and hence it needs to be removed when testing against latest and lowest dependencies.