Fix: disable git's safe.directory handling completely
#95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with GIT 2.35.3, GIT disallows operating on directories owned by other users. This is to prevent hooks from taking over the system, but this container is a single-user environment, and hooks are generally not configured on checkout anyway. This container has a different $UID/$GID than the parent worker, which performs `git clone`. With this `git config` change, we ignore this security scenario completely. Ref: https://stackoverflow.com/questions/71849415/i-cannot-add-the-parent-directory-to-safe-directory-in-git/71904131#71904131
froschdesign
approved these changes
Jun 14, 2022
|
Thanks for the quick review, @froschdesign! |
|
This needs to be replicated to operate with |
Ocramius
added a commit
to Ocramius/laminas-continuous-integration-action
that referenced
this pull request
Jun 14, 2022
…ser`) This commit repeats 42ae46d ( laminas#95 ), but this time accounts for the fact that we run our CI operations with the `testuser` account.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with GIT 2.35.3, GIT disallows operating on directories owned by other users.
This is to prevent hooks from taking over the system, but this container is a single-user
environment, and hooks are generally not configured on checkout anyway.
This container has a different $UID/$GID than the parent worker, which performs
git clone.With this
git configchange, we ignore this security scenario completely.Ref: https://stackoverflow.com/questions/71849415/i-cannot-add-the-parent-directory-to-safe-directory-in-git/71904131#71904131