Skip to content

Git safe-directory fix #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2022
Merged

Git safe-directory fix #99

merged 1 commit into from
Jun 14, 2022

Conversation

gsteel
Copy link
Member

@gsteel gsteel commented Jun 14, 2022

Moves git config call for safe.directory from the Dockerfile to the entrypoint

Ref #97

Ocramius
Ocramius approved these changes Jun 14, 2022
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try this out 🤞

@Ocramius Ocramius added the Bug Something isn't working label Jun 14, 2022
@Ocramius Ocramius added this to the 1.20.3 milestone Jun 14, 2022
@Ocramius
Copy link
Member

@gsteel I'd need this for 1.20.x though :|

@gsteel
Copy link
Member Author

gsteel commented Jun 14, 2022

Sorry - gimme a sec and I'll rebase

@Ocramius Ocramius changed the base branch from 1.21.x to 1.20.x June 14, 2022 10:15
@Ocramius Ocramius self-assigned this Jun 14, 2022
@Ocramius
Copy link
Member

Thanks @gsteel!

@Ocramius Ocramius merged commit ac5a9ac into laminas:1.20.x Jun 14, 2022
@Ocramius Ocramius changed the title Git safe-directory fix Git safe-directory fix Jun 14, 2022
@github-actions github-actions bot mentioned this pull request Jun 14, 2022
Merged
@gsteel gsteel deleted the git-config-patch branch June 14, 2022 10:23
@Ocramius
Copy link
Member

Unsure if it's using old tags, but https://github.com/laminas/laminas-validator/actions/runs/2493781041

@gsteel
Copy link
Member Author

gsteel commented Jun 14, 2022

The release build borked here… Can you re-trigger?
https://github.com/laminas/laminas-continuous-integration-action/actions/runs/2494485245

@Ocramius
Copy link
Member

Aha, good catch!

@Ocramius Ocramius mentioned this pull request Jul 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
Bug Something isn't working
Projects
None yet
Milestone
1.20.3
Development

Successfully merging this pull request may close these issues.
2 participants
@gsteel @Ocramius