Prepare for Renovate with reusable workflows

[ghostwriter]

Q	A
QA	yes

Description

Adding Renovate to Laminas, Mezzio repositories. https://gist.github.com/weierophinney/49ca8ae2b916d898dd3d4162b26ff41b

• Configure minimum supported PHP version
• Update composer dependencies
• Update to reusable Continuous Integration workflow
• Update to reusable Automatic Releases workflow

[Ocramius]

Generated composer.lock seems to be invalid - needs to be re-generated (or rolled back to just hash update)

[ghostwriter]

Unable to locate package php8.1-sqlsrv

[Ocramius]

These services should probably still run

[Ocramius]

Looks like checks didn't run, perhaps due to YAML structure/parsing error?

[ghostwriter]

@Ocramius apparently, the services keyword is not supported yet for reusable workflows.

https://docs.github.com/en/actions/using-workflows/reusing-workflows#supported-keywords-for-jobs-that-call-a-reusable-workflow

[Ocramius]

Ooof, guess we'd keep our phpunit tasks written down manually here, while excluding them from the laminas-ci integration perhaps?

[ghostwriter]

Removed reusable Continuous Integration workflow for now.

[Ocramius]

This really shouldn't be excluded :|

[ghostwriter]

This PR would fail otherwise, PHP 8.1 is not supported yet.

The "ignore_php_platform_requirements": {"8.1": true} syntax is not working.

PHP 8.1 Tests are still generated https://github.com/laminas/laminas-db/actions/runs/1887918057

[Ocramius]

We do though 🤔

laminas-db/composer.json

Line 28 in feeb1ff

"php": "^7.3 || ~8.0.0 || ~8.1.0",

[ghostwriter]

I meant PHP 8.1 CI matrix: Unable to locate package php8.1-sqlsrv

Because it can't find the packing, it automatically fails early, before reaching the steps where it uses the services defined for the container.

[Ocramius]

Yeah, I'm wondering if we can perhaps just skip sqlsrv tests for 8.1, rather than the whole 8.1 pipeline

[ghostwriter]

I thought about that, but in laminas-ci.json the extensions we define for all PHP version, cause the script to fail on PHP 8.1 because one or more of the extensions doesn’t exist.

"extensions": [
        "pdo-mysql",
        "pdo-pgsql",
        "pdo-sqlite",
        "mysqli",
        "pgsql",
        "sqlite3",
        "sqlsrv"
    ],

if we remove this then we will lose those extensions on all PHP versions.

[weierophinney]

Actually, we need to update the laminas-continuous-integration-action. MS released v5.10.0 of the sqlsrv extension, and it has PHP 8.1 support. I'll add that to the CI action, and then we should be able to test 8.1 here.

[weierophinney]

I wonder why no actions triggered with my last push...

[Ocramius]

@weierophinney github partial outage

[Ocramius]

We need to do something like pushing + squashing an empty commit here

[weierophinney]

Yes... But waiting for github status to go green (actions still has degraded performance).

…

On Wed, Mar 23, 2022, 12:20 PM Marco Pivetta ***@***.***> wrote: We need to do something like pushing + squashing an empty commit here — Reply to this email directly, view it on GitHub <#239 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAGKV7L6HDC726PV2POX43VBNHGTANCNFSM5O5NRITQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[weierophinney]

@ghostwriter I'll figure out why the CI container isn't working, and get things sorted. Your work is done here; thanks for the patch!

[weierophinney]

Assuming tests pass after this run, 🚢

(Note: previous run passed, but the latest commit removes usage of a deprecated function.)

[weierophinney]

@ghostwriter You overwrote a change I'd pushed to .laminas-ci.json:

    "ignore_php_platform_requirements": {
        "8.1": true
    }

That will allow deps to install in 8.1, which should allow tests to pass.

[weierophinney]

Thanks, @ghostwriter !