Adds support for PHP 8.1 #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
froschdesign
force-pushed
the
feature/php-8.1-support
branch
from
a053be9 to
f7e7730
Compare
Ocramius
requested changes
Dec 3, 2021
|
A rebase + |
Signed-off-by: Frank Brückner <[email protected]>
Signed-off-by: Frank Brückner <[email protected]>
froschdesign
force-pushed
the
feature/php-8.1-support
branch
from
a9097b3 to
34283f2
Compare
Signed-off-by: Frank Brückner <[email protected]>
Signed-off-by: Frank Brückner <[email protected]>
Ocramius
approved these changes
Dec 7, 2021
There was a problem hiding this comment.
LGTM. @froschdesign what should we do about PHPCS failures? 🤔
I will solve the problem but no hurry, because PHP 8.1 itself is not yet ready. 😜 |
Signed-off-by: Frank Brückner <[email protected]>
Signed-off-by: Frank Brückner <[email protected]>
Signed-off-by: Frank Brückner <[email protected]>
Signed-off-by: Frank Brückner <[email protected]>
Signed-off-by: Frank Brückner <[email protected]>
Signed-off-by: Frank Brückner <[email protected]>
Signed-off-by: Frank Brückner <[email protected]>
Signed-off-by: Frank Brückner <[email protected]>
Signed-off-by: Frank Brückner <[email protected]>
|
can be merge ? |
Ocramius
approved these changes
Dec 12, 2021
|
@Ocramius should it be merged to 2.13.x branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25