Skip to content

Improve error message when empty notebook is passed #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

Zethson
Copy link
Member

@Zethson Zethson commented Dec 26, 2023

Fixes #274

@Zethson Zethson requested a review from Koncopd December 26, 2023 22:05
Copy link

github-actions bot commented Dec 26, 2023

Copy link

codecov bot commented Dec 26, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (c316156) 89.39% compared to head (24d9d84) 89.06%.

Files Patch % Lines
nbproject/dev/_notebook.py 33.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #275      +/-   ##
==========================================
- Coverage   89.39%   89.06%   -0.34%     
==========================================
  Files          24       24              
  Lines        1028     1033       +5     
==========================================
+ Hits          919      920       +1     
- Misses        109      113       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to pull request December 26, 2023 22:07 Inactive
@Zethson Zethson merged commit 463eb85 into main Jan 4, 2024
@Zethson Zethson deleted the fix/empty_notebook_tracking branch January 4, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error message when attempting to track empty notebooks
1 participant