Skip to content

🚸 Support inferring notebook path when executed through nbconvert #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 18, 2025

Conversation

falexwolf
Copy link
Member

@falexwolf falexwolf commented Apr 18, 2025

Enables to infer the notebook path when run through nbconvert:

jupyter nbconvert --to notebook --execute test-nbconvert.ipynb

Copy link

codecov bot commented Apr 18, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 30 lines in your changes missing coverage. Please review.

Project coverage is 87.83%. Comparing base (13a5392) to head (cad692f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
nbproject/dev/_jupyter_communicate.py 50.00% 30 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #288      +/-   ##
==========================================
- Coverage   88.47%   87.83%   -0.65%     
==========================================
  Files          24       24              
  Lines        1059     1118      +59     
==========================================
+ Hits          937      982      +45     
- Misses        122      136      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Koncopd
Copy link
Member

Koncopd commented Apr 18, 2025

This is great.

Just a question - do we really want warnings from this?

@falexwolf
Copy link
Member Author

This will only print warnings if everything else fails. I agree that it could even then be annoying. 🤔

But I'd run it like this in production for a while now and then we can adjust. I expect that this will be the main part of nbproject that we'll keep iterating on.

@Koncopd
Copy link
Member

Koncopd commented Apr 18, 2025

This will only print warnings if everything else fails

Yep, i see this is at the very end. Fine, i think, not a very common situation that everything else fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants