Fix all warnings #28
Merged
Fix all warnings #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The outer reference in this type test cannot be checked at run time
|
Testing in scala/scala3#3541 |
| @@ -478,7 +478,7 @@ trait BCodeBodyBuilder extends BCodeSkelBuilder { | |||
| * Otherwise it's safe to call from multiple threads. | |||
| */ | |||
| def genConstant(const: Constant): Unit = { | |||
| (const.tag: @switch) match { | |||
| (const.tag/*: @switch*/) match { | |||
There was a problem hiding this comment.
It would be interesting to know why Dotty cannot emit a switch here but scalac can
There was a problem hiding this comment.
My bad, scalac also emits the warning. However I don't see why neither scalac nor notty can emit a switch. I think the user would benefit from a bit more information in the warning
allanrenucci
approved these changes
Nov 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.