Skip to content

Conversation

@MANYA12-STAR
Copy link

Description

This PR adds first-class support for configurable request timeouts in PowerBIDataset for both synchronous (run) and asynchronous (arun) execution paths.

Key improvements:

  • Introduced a new request_timeout field on PowerBIDataset, enabling instance-level timeout configuration.
  • Added input validation to prevent invalid timeout values.
  • Updated run() and arun() to use explicit timeouts when provided, or fall back to the instance default.
  • Implemented async timeout handling using aiohttp.ClientTimeout.
  • Added a complete unit test suite (test_powerbi_timeout.py) covering:
    • default timeout behaviour
    • explicit timeout overrides
    • async behaviour with internal/external sessions
    • invalid timeout values
  • Ensures fully backward-compatible behavior.

Issue

Fixes #332 — Add configurable timeout support and improve reliability of PowerBI utilities.

Dependencies

No new dependencies added.
All existing optional dependencies remain optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PowerBIDataset.run() does not accept timeout as arguments

1 participant