Fix/chatgpt loader bug #466
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in
ChatGPTLoaderwhere the last message in the conversation was being dropped when using the default initialization arguments.The Bug:
The
__init__method had a default value ofnum_logs=-1. In theloadmethod, the code used slicingdata[:self.num_logs]whennum_logswas truthy. Since-1is truthy, this resulted indata[:-1], which excluded the last element of the list.The Fix:
Changed the default value of
num_logsto0(which implies loading all logs), ensuring the slicing logic correctly handles the default case.Testing:
tests/unit_tests/document_loaders/test_chatgpt.py.num_logsparameter works as expected.chatgpt.pyfrom 0% to 100%.Issue
Fixes #465
Dependencies
None