Backport fix: prevent PDF image extraction from being skipped #481
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧪 Add regression test for PDF image extraction (PyMuPDF)
Summary
Adds a regression test to ensure that
extract_images=Truedoes not silently skipimages when using
PyMuPDFParser.In
langchain-community==0.4.1, image extraction was broken due to a prematureempty-buffer check, causing all images to be skipped with no warning. This test
would have failed in that version.
Why this matters
This test ensures the expected behavior remains intact and prevents future
regressions.
Notes
main