Skip to content

Conversation

hemidactylus
Copy link
Contributor

@hemidactylus hemidactylus commented Sep 4, 2025

Copy link

vercel bot commented Sep 4, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
langchain Ignored Ignored Preview Sep 4, 2025 10:39pm

Copy link

codspeed-hq bot commented Sep 4, 2025

CodSpeed WallTime Performance Report

Merging #32821 will not alter performance

Comparing hemidactylus:SL-vstore-stdtests-unordered-get_by_ids (d036c99) with master (bc91a48)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 13 untouched benchmarks

Copy link

codspeed-hq bot commented Sep 4, 2025

CodSpeed Instrumentation Performance Report

Merging #32821 will not alter performance

Comparing hemidactylus:SL-vstore-stdtests-unordered-get_by_ids (d036c99) with master (bc91a48)

Summary

✅ 14 untouched benchmarks

@mdrxy mdrxy changed the title fix(standard-tests): standard vectorstore tests accept out-of-order get_by_ids fix(standard-tests): standard vectorstore tests accept out-of-order get_by_ids Sep 5, 2025
@mdrxy mdrxy added the standard-tests Related to the package `standard-tests` label Sep 5, 2025
@eyurtsev eyurtsev self-assigned this Sep 8, 2025
@eyurtsev eyurtsev merged commit 390606c into langchain-ai:master Sep 8, 2025
130 checks passed
@hemidactylus hemidactylus deleted the SL-vstore-stdtests-unordered-get_by_ids branch September 9, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
standard-tests Related to the package `standard-tests`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

standard-tests: some vector store tests mistakenly assume get_by_ids preserves document order
4 participants