fix(openai): improve error handling for null choices in OpenAI-compatible APIs #34515
+2,129
−1,895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for OpenRouter's reasoning_details field as provider-specific metadata stored in additional_kwargs. This allows OpenRouter users to access structured reasoning metadata (tokens, steps, etc.) without modifying the message content structure. - Store reasoning_details in additional_kwargs for both non-streaming and streaming scenarios - Handle reasoning_details at response level in _create_chat_result - Add comprehensive tests including streaming delta merging verification - Rely on LangChain's merge_dicts() for automatic delta merging when chunks are combined via AIMessageChunk.__add__() This follows the same pattern as other provider-specific fields and maintains backward compatibility.
…ible APIs - Provide more diagnostic information when choices is null - Handle error field in response with better context - Add comprehensive tests for null choices scenarios - Addresses issue langchain-ai#32252 with vLLM OpenAI-compatible API This improves error messages when OpenAI-compatible APIs (like vLLM) return null choices, helping users diagnose API compatibility issues.
github-actions
bot
added
integration
CodSpeed Performance ReportMerging #34515 will not alter performanceComparing Summary
Footnotes
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32252
Improves error handling and diagnostic information when OpenAI-compatible APIs (like vLLM) return null choices. The error messages now include more context about the error type, message, and response structure to help users diagnose API compatibility issues.
Changes:
_create_chat_resultto check for null choices before processing error fieldsNote on uv.lock changes:
The
uv.lockfile was updated as part of resolving merge conflicts with upstream master, not due to adding new dependencies.AI Disclaimer:
This contribution was created with assistance from AI tools for code implementation and testing.