feat(core): add approximate image token counting support #34529
+32
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
feat(core): add approximate image token counting support
Description
This PR addresses a TODO in langchain_core/messages/utils.py to support approximate token counting for image blocks in messages.
Issue Addressed
Previously, count_tokens_approximately would fall back to
repr(content)for any non-string content (including lists of blocks). Forimage_urlblocks, this resulted in drastically undercounting tokens (only counting the URL characters), typically around ~30-40 tokens instead of the actual cost (~85) of an image.Changes
type: image_urlblocks, assigning a constant cost of 85 tokens (standard low-detail approximation).Verification
uv run --group test pytest tests/unit_tests/messages/test_utils.py