chore(core): Update LangChainTracer to use Pydantic v2 methods #34541
+269
−131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
CodSpeed Performance ReportMerging #34541 will not alter performanceComparing
|
angus-langchain
changed the title
github-actions
bot
added
the
infra
github-actions
bot
added
infra
mdrxy
reviewed
Dec 31, 2025
| res.key, | ||
| score=res.score, | ||
| value=res.value, | ||
| value=res.value, # type: ignore[arg-type] |
Member
There was a problem hiding this comment.
is this related to pydantic migration or masking a separate issue?
mdrxy
reviewed
Dec 31, 2025
Comment on lines
+79
to
+80
| if hasattr(get_env_var, "cache_clear"): | ||
| get_env_var.cache_clear() # type: ignore[attr-defined] |
Member
There was a problem hiding this comment.
is this a separate langsmith API change?
mdrxy
approved these changes
Dec 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In LangSmith 0.6.0, we update the Run and RunTree object to use pydantic v2. This PR adds support for this change by using the correct method for langsmith >= 0.6.0 pydantic >= v2. It has backwards compatibility for older sdk versions as well with deprecated methods