Skip to content

Fix tests and build #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 2, 2020
Merged

Fix tests and build #41

merged 5 commits into from
Jan 2, 2020

Conversation

jessarcher
Copy link
Collaborator

Fixes #40 by:

  • Updating to latest PHPUnit and Mockery
  • Updating test cases to work with the above
  • Removing invalid PHPUnit configuration
  • Update test expectations to match implementation

@jessarcher jessarcher marked this pull request as ready for review January 2, 2020 07:22
@jessarcher jessarcher mentioned this pull request Jan 2, 2020
Merged
atymic
atymic approved these changes Jan 2, 2020
View reviewed changes
Copy link
Member

@atymic atymic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jessarcher!

@atymic atymic merged commit 653a85b into laravel-notification-channels:master Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atymic atymic atymic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build isn't really passing
2 participants
@jessarcher @atymic