Skip to content

[15.x] Catch missing payment intents #1704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
taylorotwell merged 3 commits into from
Aug 20, 2024
Merged

[15.x] Catch missing payment intents #1704

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c327208
Catch missing payment intents
shatterproof Aug 12, 2024
6775f97
Abort not found payment intent
shatterproof Aug 19, 2024
8629cab
Update PaymentController.php
taylorotwell Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/Http/Controllers/PaymentController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
use Laravel\Cashier\Cashier;
use Laravel\Cashier\Http\Middleware\VerifyRedirectUrl;
use Laravel\Cashier\Payment;
use Stripe\Exception\InvalidRequestException as StripeInvalidRequestException;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;

class PaymentController extends Controller
{
Expand All @@ -25,12 +27,18 @@ public function __construct()
*
* @param string $id
* @return \Illuminate\Contracts\View\View
*
* @throws \Symfony\Component\HttpKernel\Exception\NotFoundHttpException
*/
public function show($id)
{
$payment = new Payment(Cashier::stripe()->paymentIntents->retrieve(
$id, ['expand' => ['payment_method']])
);
try {
$payment = new Payment(Cashier::stripe()->paymentIntents->retrieve(
$id, ['expand' => ['payment_method']])
);
} catch (StripeInvalidRequestException $exception) {
throw new NotFoundHttpException;
}

$paymentIntent = Arr::only($payment->asStripePaymentIntent()->toArray(), [
'id', 'status', 'payment_method_types', 'client_secret', 'payment_method',
Expand Down