Skip to content

[2FA] Change to use timestamp for confirming 2fa #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 21, 2022

Conversation

Jubeki
Copy link
Contributor

@Jubeki Jubeki commented Feb 19, 2022

Use Timestamps instead of boolean for confirming.

@Jubeki Jubeki changed the title Change to use timestamp for confirming 2fa [2FA] Change to use timestamp for confirming 2fa Feb 19, 2022
@Jubeki Jubeki mentioned this pull request Feb 19, 2022
@taylorotwell taylorotwell merged commit eb622f0 into laravel:2fa-confirm Feb 21, 2022
@Jubeki Jubeki deleted the 2fa-confirm-with-timestamp branch February 21, 2022 15:30
taylorotwell added a commit that referenced this pull request Feb 21, 2022
* first pass at confirmable 2fa

* working on tests

* additional tests

* Apply fixes from StyleCI

* dont interact with column in feature not enabled

* adjust migration

* Apply fixes from StyleCI

* adjust tests

* [2FA] Change to use timestamp for confirming 2fa (#359)

* Change to use timestamp for confirming 2fa

* Fix nullable column

* Fix nullable column in tests

* Add unsaved changes

* update check and test

Co-authored-by: Taylor Otwell <[email protected]>
Co-authored-by: StyleCI Bot <[email protected]>
Co-authored-by: Julius Kiekbusch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants