Skip to content

remove limiter from the registration view route #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

akunbeben
Copy link

@akunbeben akunbeben commented Apr 20, 2023

I notice that #460 is adding a rate limiter for registration. It shouldn't be applied to the registration view route, in many cases it might we as developers need to refresh the page multiple times for any reason.

For example, I ran php artisan optimize:clear and vite trigger the reload many times here and it will reach the throttle limit.

Details

2023-04-21.07-13-50.mp4

@driesvints
Copy link
Member

But this is off by default? How is this affecting you?

@taylorotwell
Copy link
Member

Agree with @driesvints - it's off by default?

@trbsi
Copy link
Contributor

trbsi commented Apr 26, 2023

I would have to agree with akunbeben. Rate limiter should not be on a view route. Let's say I want to limit registration 5 per day. If a person opens view route 5 times (just opens without actually submitting the form), a person will start getting 429 error

I shouldn't have put the limiter to the view route

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants