remove limiter from the registration view route #461
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I notice that #460 is adding a rate limiter for registration. It shouldn't be applied to the registration view route, in many cases it might we as developers need to refresh the page multiple times for any reason.
For example, I ran
php artisan optimize:clear
and vite trigger the reload many times here and it will reach the throttle limit.Details
2023-04-21.07-13-50.mp4