Changed migration of users table #586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed unused use statement
crynobone
added a commit
that referenced
this pull request
Jan 13, 2025
Avoid regression bug from #586 Signed-off-by: Mior Muhammad Zaki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the laravel migration is run with TwoFactorAuthentication disabled it will not create the
two_factor_confirmed_atfield in database, but migration is completed.If you would enable the TwoFactorAuthentication later this will result in a DBException and you have to create a new migration manually.
It would be better to just create the database field, which would allow enabled/disabling of 2FA without migration.