Allow RedirectIfTwoFactorAuthenticatable to be resolved via the Container
#599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows
RedirectIfTwoFactorAuthenticatableto be resolved via the container, making it easier to bind a custom redirect action class.Currently, the
RedirectIfTwoFactorAuthenticatableaction stores login information (i.e.login.id) in the session, which prevents Fortify’s existing 2FA flow from being used in mobile apps. As a result, mobile support requires custom logic.Although it’s possible to override the redirect action using
Fortify::authenticateThrough(...), other key authentication actions in the login flow are already container-resolvable and easily swappable. This PR also brings consistency by making RedirectIfTwoFactorAuthenticatable resolvable in the same way.