Components: The ")" character, this may cause an error

[mxgrim]

• Laravel Version: 8.34.0
• PHP Version: 7.4.16
• Database Driver & Version: -

Description:

If you use the ")" character in a declared attribute of a component, this will result in an error:
ParseError
syntax error, unexpected ..

Steps To Reproduce:

Declare an attribute on a component:
public function __construct($title = '')

Run from any .blade.php:
<x-forms.input title="test test )"/>

[selcukcukur]

Can you share all the codes you use exactly because I have not encountered such a problem, you may be making a mistake while using it. @mxgrim

[selcukcukur]

I think this is a problem caused by a user error. I applied the necessary tests, but I did not encounter the same error. @driesvints

[mxgrim]

app/View/Components/Forms/Test.php

<?php

namespace App\View\Components\Forms;

use Illuminate\View\Component;

class Test extends Component
{
    /**
     * Create a new component instance.
     *
     * @return void
     */
    public function __construct($test = '')
    {
        //
    }

    /**
     * Get the view / contents that represent the component.
     *
     * @return \Illuminate\Contracts\View\View|\Closure|string
     */
    public function render()
    {
        return view('components.forms.test');
    }
}

resourses/views/components/forms/test.blade.php

<div>
    test
</div>

resourses/views/index.blade.php

<x-forms.test test=")"/>

---

Error:

ParseError
syntax error, unexpected 'forms' (T_STRING), expecting ']'

Compiled file (storage/framework/views/...):

<?php if (isset($component)) { $__componentOriginal40e62d942e0a3dbd05627ad21d1c6a1a4a3b111f = $component; } ?>
<?php $component = $__env->getContainer()->make(App\View\Components\Forms\Test::class, ['test' => '); ?>
<?php $component->withName('forms.test'); ?>
<?php if ($component->shouldRender()): ?>
<?php $__env->startComponent($component->resolveView(), $component->data()); ?>'])
<?php $component->withAttributes([]); ?>
<?php if (isset($__componentOriginal40e62d942e0a3dbd05627ad21d1c6a1a4a3b111f)): ?>
<?php $component = $__componentOriginal40e62d942e0a3dbd05627ad21d1c6a1a4a3b111f; ?>
<?php unset($__componentOriginal40e62d942e0a3dbd05627ad21d1c6a1a4a3b111f); ?>
<?php endif; ?>
<?php echo $__env->renderComponent(); ?>
<?php endif; ?>

The problem is here:
make(App\View\Components\Forms\Test::class, ['test' => '); ?>

[selcukcukur]

framework/src/Illuminate/View/Compilers/Concerns/CompilesComponents.php

Line 25 in d118c0d

[$component, $alias, $data] = strpos($expression, ',') !== false

framework/src/Illuminate/View/Compilers/Concerns/CompilesComponents.php

Line 26 in d118c0d

? array_map('trim', explode(',', trim($expression, '()'), 3)) + ['', '', '']

framework/src/Illuminate/View/Compilers/Concerns/CompilesComponents.php

Line 27 in d118c0d

: [trim($expression, '()'), '', ''];

The problem is here. I'm sending a pull request.

[driesvints]

I've tracked it down to compileStatements in BladeCompiler which incorrectly removes the ']) part at the end. Currently trying to see if I can adjust the regex.

[driesvints]

Here's a PR with a failing test: #36843