Exception handler crashes with Phiki error

[pxlrbt]

Laravel Version

12.30.1

PHP Version

8.4.12

Database Driver & Version

No response

Description

The error handler crashes with a Phiki error in some weird combinations.

Steps To Reproduce

Cause a LazyLoadingViolationException from inside an model attribute.
Does not work if the exception is thrown directly.

Repo:
https://github.com/pxlrbt/bug-exception-handler

[hosni]

Hi @pxlrbt

This happens because a special character ⋅ was used when joining two strings:
https://github.com/pxlrbt/bug-exception-handler/blob/c112857a7dd0f8f6b5456794dc6d18dc2d5b8a16/app/Models/ModelA.php#L24-L26

This causes mb_ereg_search_init to fail here:
https://github.com/phikiphp/phiki/blob/fe51fe6dc31856cd776fd1b04ee74053a4271644/src/TextMate/PatternSearcher.php#L40-L42

mb_ereg_search_init cannot handle special characters like the ⋅ character you used.

I’m not sure how to fix it completely, but I do know that $lineText should be utf8_decoded before being passed to mb_ereg_search_init. That way, it displays properly.

Or simply remove that special character 🙄

[pxlrbt]

@hosni Thanks for the explanation. That explains why I had a hard time recreating it 😅

[hosni]

@pxlrbt yw. Yeah, it’s a tricky one 😅

[crynobone]

I believe this should be reported to phikiphp/phiki, thank you

[hosni]

@crynobone This issue has been fixed in: phikiphp/phiki#122.
The latest release is v2.0.3, which doesn’t include the patch. It will likely be included in the next bug-fix release (e.g. v2.0.4).

I suggest that once the patch is released, we update the framework’s dependency from "phiki/phiki": "^2.0.0" to ^2.0.4 to ensure we’re always on a fixed version.

I’m keeping an eye on the Phiki repo, and once v2.0.4 is published, I can open a PR to update the dependency. Please confirm if you’re okay with this plan.

[yabdab]

Isn't this a Laravel bug they they need to fix?

[hosni]

Isn't this a Laravel bug they they need to fix?

@yabdab No, that's not related to framework.
The syntax highlighter should handle the given code properly.

And also it's not needed anymore, phiki was removed in commit: 06cbc6e in PR #57184

Related file is:
src/Illuminate/Foundation/resources/exceptions/renderer/components/syntax-highlight.blade.php