LARAVEL_START already defined in ComposerScripts::prePackageUninstall

[htulibacki]

Laravel Version

12.32.1

PHP Version

8.4.13

Database Driver & Version

No response

Description

I think that LARAVEL_START is being redeclared in Illuminate\Foundation\ComposerScripts::prePackageUninstall when trying to uninstall more than one package at a time,

Steps To Reproduce

1. Install a fresh Laravel.
2. Try to uninstall Laravel Sail for an intstance (it will remove symfony/yaml, so the hook will be called a second time).

[rforced]

Related #57144
@cosmastech can you take a look?

[cosmastech]

This is resolved in the latest release (12.32.3). Thanks to @htulibacki and @rforced for surfacing it!

[htulibacki]

@cosmastech problem with LARAVEL_START is resolved, but there is another one.

When you call require_once on a file that has already been included, it returns true instead of including the file again. This causes an error on line 73: Call to a member function make() on true.

[cosmastech]

@cosmastech problem with LARAVEL_START is resolved, but there is another one.

When you call require_once on a file that has already been included, it returns 1 instead of including the file again. This causes an error on line 73: Call to a member function make() on true.

Thanks for the info!

Would you be so kind as to give me your composer.json and the command you're executing to remove packages. It will help me with debugging. 🙏

[htulibacki]

composer remove laravel/sail --dev

In ComposerScripts.php line 73:

  [Error]
  Call to a member function make() on true

Exception trace:
  at /Users/hubert/Code/Projects/grafmag/vendor/laravel/framework/src/Illuminate/Foundation/ComposerScripts.php:73
 Illuminate\Foundation\ComposerScripts::prePackageUninstall() at phar:///Users/hubert/Library/Application Support/Herd/bin/composer/src/Composer/EventDispatcher/EventDispatcher.php:508
 Composer\EventDispatcher\EventDispatcher->executeEventPhpScript() at phar:///Users/hubert/Library/Application Support/Herd/bin/composer/src/Composer/EventDispatcher/EventDispatcher.php:284
 Composer\EventDispatcher\EventDispatcher->doDispatch() at phar:///Users/hubert/Library/Application Support/Herd/bin/composer/src/Composer/EventDispatcher/EventDispatcher.php:158
 Composer\EventDispatcher\EventDispatcher->dispatchPackageEvent() at phar:///Users/hubert/Library/Application Support/Herd/bin/composer/src/Composer/Installer/InstallationManager.php:369
 Composer\Installer\InstallationManager->executeBatch() at phar:///Users/hubert/Library/Application Support/Herd/bin/composer/src/Composer/Installer/InstallationManager.php:322
 Composer\Installer\InstallationManager->downloadAndExecuteBatch() at phar:///Users/hubert/Library/Application Support/Herd/bin/composer/src/Composer/Installer/InstallationManager.php:221
 Composer\Installer\InstallationManager->execute() at phar:///Users/hubert/Library/Application Support/Herd/bin/composer/src/Composer/Installer.php:839
 Composer\Installer->doInstall() at phar:///Users/hubert/Library/Application Support/Herd/bin/composer/src/Composer/Installer.php:649
 Composer\Installer->doUpdate() at phar:///Users/hubert/Library/Application Support/Herd/bin/composer/src/Composer/Installer.php:298
 Composer\Installer->run() at phar:///Users/hubert/Library/Application Support/Herd/bin/composer/src/Composer/Command/RemoveCommand.php:299
 Composer\Command\RemoveCommand->execute() at phar:///Users/hubert/Library/Application Support/Herd/bin/composer/vendor/symfony/console/Command/Command.php:298
 Symfony\Component\Console\Command\Command->run() at phar:///Users/hubert/Library/Application Support/Herd/bin/composer/vendor/symfony/console/Application.php:1040
 Symfony\Component\Console\Application->doRunCommand() at phar:///Users/hubert/Library/Application Support/Herd/bin/composer/vendor/symfony/console/Application.php:301
 Symfony\Component\Console\Application->doRun() at phar:///Users/hubert/Library/Application Support/Herd/bin/composer/src/Composer/Console/Application.php:400
 Composer\Console\Application->doRun() at phar:///Users/hubert/Library/Application Support/Herd/bin/composer/vendor/symfony/console/Application.php:171
 Symfony\Component\Console\Application->run() at phar:///Users/hubert/Library/Application Support/Herd/bin/composer/src/Composer/Console/Application.php:137
 Composer\Console\Application->run() at phar:///Users/hubert/Library/Application Support/Herd/bin/composer/bin/composer:98
 require() at /Users/hubert/Library/Application Support/Herd/bin/composer:29

[cosmastech]

composer remove laravel/sail --dev

In ComposerScripts.php line 73:

  [Error]
  Call to a member function make() on true

Exception trace:
  at /Users/hubert/Code/Projects/grafmag/vendor/laravel/framework/src/Illuminate/Foundation/ComposerScripts.php:73
 Illuminate\Foundation\ComposerScripts::prePackageUninstall() at phar:///Users/hubert/Library/Application Support/Herd/bin/composer/src/Composer/EventDispatcher/EventDispatcher.php:508
 Composer\EventDispatcher\EventDispatcher->executeEventPhpScript() at phar:///Users/hubert/Library/Application Support/Herd/bin/composer/src/Composer/EventDispatcher/EventDispatcher.php:284
 Composer\EventDispatcher\EventDispatcher->doDispatch() at phar:///Users/hubert/Library/Application Support/Herd/bin/composer/src/Composer/EventDispatcher/EventDispatcher.php:158
 Composer\EventDispatcher\EventDispatcher->dispatchPackageEvent() at phar:///Users/hubert/Library/Application Support/Herd/bin/composer/src/Composer/Installer/InstallationManager.php:369
 Composer\Installer\InstallationManager->executeBatch() at phar:///Users/hubert/Library/Application Support/Herd/bin/composer/src/Composer/Installer/InstallationManager.php:322
 Composer\Installer\InstallationManager->downloadAndExecuteBatch() at phar:///Users/hubert/Library/Application Support/Herd/bin/composer/src/Composer/Installer/InstallationManager.php:221
 Composer\Installer\InstallationManager->execute() at phar:///Users/hubert/Library/Application Support/Herd/bin/composer/src/Composer/Installer.php:839
 Composer\Installer->doInstall() at phar:///Users/hubert/Library/Application Support/Herd/bin/composer/src/Composer/Installer.php:649
 Composer\Installer->doUpdate() at phar:///Users/hubert/Library/Application Support/Herd/bin/composer/src/Composer/Installer.php:298
 Composer\Installer->run() at phar:///Users/hubert/Library/Application Support/Herd/bin/composer/src/Composer/Command/RemoveCommand.php:299
 Composer\Command\RemoveCommand->execute() at phar:///Users/hubert/Library/Application Support/Herd/bin/composer/vendor/symfony/console/Command/Command.php:298
 Symfony\Component\Console\Command\Command->run() at phar:///Users/hubert/Library/Application Support/Herd/bin/composer/vendor/symfony/console/Application.php:1040
 Symfony\Component\Console\Application->doRunCommand() at phar:///Users/hubert/Library/Application Support/Herd/bin/composer/vendor/symfony/console/Application.php:301
 Symfony\Component\Console\Application->doRun() at phar:///Users/hubert/Library/Application Support/Herd/bin/composer/src/Composer/Console/Application.php:400
 Composer\Console\Application->doRun() at phar:///Users/hubert/Library/Application Support/Herd/bin/composer/vendor/symfony/console/Application.php:171
 Symfony\Component\Console\Application->run() at phar:///Users/hubert/Library/Application Support/Herd/bin/composer/src/Composer/Console/Application.php:137
 Composer\Console\Application->run() at phar:///Users/hubert/Library/Application Support/Herd/bin/composer/bin/composer:98
 require() at /Users/hubert/Library/Application Support/Herd/bin/composer:29

Thank you!

Could you do me one more favor:

Go into vendor/laravel/framework/src/Illuminate/Foundation/ComposerScripts.php and replace the prePackageUninstall function with this?

    public static function prePackageUninstall(PackageEvent $event)
    {
        $bootstrapFile = dirname($vendorDir = $event->getComposer()->getConfig()->get('vendor-dir')).'/bootstrap/app.php';

        if (! file_exists($bootstrapFile)) {
            return;
        }

        require_once $vendorDir.'/autoload.php';

        if (! defined('LARAVEL_START')) {
            define('LARAVEL_START', microtime(true));
        }

        require_once $bootstrapFile;

        /** @var Application $app */
        $app = Container::getInstance();
        $app->make(Kernel::class)->bootstrap();

        /** @var \Composer\DependencyResolver\Operation\UninstallOperation $uninstallOperation */
        $uninstallOperation = $event->getOperation()->getPackage();

        $app['events']->dispatch('composer_package.'.$uninstallOperation->getName().':pre_uninstall');
    }

It appears to be working locally for me, but would love a second set of eyes.

[htulibacki]

It seems to be working for me as well.

[cosmastech]

Added you as a co-author of the commit. Thanks again @htulibacki!

[htulibacki]

Resolved in 12.32.4.